Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
217fbb8
feat: TT-208 add new column in activity-list
thegreatyamori Apr 19, 2021
6c1c06f
feat: TT-208 add switch status button in column
thegreatyamori Apr 19, 2021
dc10fcf
feat: TT-208 remove delete button & assign openmodal to switch
thegreatyamori Apr 20, 2021
fb37b3b
feat: TT-208 connect switch btn with ngrx flux
thegreatyamori Apr 20, 2021
f0275f8
feat: TT-208 update ngrx delete flux
thegreatyamori Apr 20, 2021
e8ee50f
feat: TT-208 show active activities in entry & details fields
thegreatyamori Apr 21, 2021
a62c980
feat: TT-208 change ui-switch to button
thegreatyamori Apr 22, 2021
5c19c86
fix: TT-208 display the required activities when clicking on time en…
thegreatyamori Apr 26, 2021
a76051c
Merge branch 'master' into TT-208-don't-allow-deleting-activities
thegreatyamori Apr 26, 2021
aa698ee
feat: TT-208 add new column in activity-list
thegreatyamori Apr 26, 2021
5ca9a8f
feat: TT-208 add switch status button in column
thegreatyamori Apr 26, 2021
17d5acd
feat: TT-208 remove delete button & assign openmodal to switch
thegreatyamori Apr 26, 2021
90742ad
feat: TT-208 connect switch btn with ngrx flux
thegreatyamori Apr 26, 2021
4977dff
feat: TT-208 update ngrx delete flux
thegreatyamori Apr 26, 2021
1d0107d
feat: TT-208 show active activities in entry & details fields
thegreatyamori Apr 21, 2021
5808250
feat: TT-208 change ui-switch to button
thegreatyamori Apr 22, 2021
286033c
fix: TT-208 display the required activities when clicking on time en…
thegreatyamori Apr 26, 2021
3a5e107
feat: TT-208 rebase on latest master commit
thegreatyamori Apr 26, 2021
1c9ee96
fix: TT-208 merging conflicts
thegreatyamori Apr 26, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: TT-208 rebase on latest master commit
  • Loading branch information
thegreatyamori committed Apr 26, 2021
commit 3a5e107ba04e2f54c596f4bc52666a19e7d06409
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Action } from '@ngrx/store';

import { Activity, Status } from './../../shared/models/activity.model';
import { Activity, ActivityStatus } from './../../shared/models/activity.model';

export enum ActivityManagementActionTypes {
LOAD_ACTIVITIES = '[ActivityManagement] LOAD_ACTIVITIES',
Expand Down Expand Up @@ -65,7 +65,7 @@ export class ArchiveActivity implements Action {
export class ArchiveActivitySuccess implements Action {
public readonly type = ActivityManagementActionTypes.ARCHIVE_ACTIVITY_SUCCESS;

constructor(public payload: Status) { }
constructor(public payload: ActivityStatus) { }
}

export class ArchiveActivityFail implements Action {
Expand Down Expand Up @@ -100,7 +100,7 @@ export class UnarchiveActivity implements Action {
export class UnarchiveActivitySuccess implements Action {
public readonly type = ActivityManagementActionTypes.UNARCHIVE_ACTIVITY_SUCCESS;

constructor(public payload: Status) { }
constructor(public payload: ActivityStatus) { }
}
export class UnarchiveActivityFail implements Action {
public readonly type = ActivityManagementActionTypes.UNARCHIVE_ACTIVITY_FAIL;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { catchError, map, mergeMap } from 'rxjs/operators';
import { ToastrService } from 'ngx-toastr';

import * as actions from './activity-management.actions';
import { Activity, Status } from './../../shared/models/activity.model';
import { Activity, ActivityStatus } from './../../shared/models/activity.model';
import { ActivityService } from './../services/activity.service';

@Injectable()
Expand Down Expand Up @@ -59,7 +59,7 @@ export class ActivityEffects {
id: action.activityId,
status: 'inactive'
})),
mergeMap((activity: Status) =>
mergeMap((activity: ActivityStatus) =>
this.activityService.deleteActivity(activity.id).pipe(
map(() => {
this.toastrService.success(INFO_DELETE_SUCCESSFULLY);
Expand Down Expand Up @@ -99,7 +99,7 @@ export class ActivityEffects {
status: 'active'
})
),
mergeMap((activity: Status) =>
mergeMap((activity: ActivityStatus) =>
this.activityService.updateActivity(activity).pipe(
map((activityData) => {
this.toastrService.success(INFO_SAVED_SUCCESSFULLY);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Activity, Status } from './../../shared/models/activity.model';
import { Activity, ActivityStatus } from './../../shared/models/activity.model';
import * as actions from './activity-management.actions';
import { activityManagementReducer, ActivityState } from './activity-management.reducers';

Expand Down Expand Up @@ -68,7 +68,7 @@ describe('activityManagementReducer', () => {
const currentActivity = { ...activity };
currentActivity.status = 'active';
const currentState: ActivityState = { data: [currentActivity], isLoading: false, message: '', activityIdToEdit: '' };
const activityArchived: Status = { id: '1', status: 'inactive' };
const activityArchived: ActivityStatus = { id: '1', status: 'inactive' };
const action = new actions.ArchiveActivitySuccess(activityArchived);
const state = activityManagementReducer(currentState, action);

Expand Down Expand Up @@ -125,7 +125,7 @@ describe('activityManagementReducer', () => {

it('on UnarchiveActivitySuccess, status activity is change to \"active\" in the store', () => {
const currentState: ActivityState = { data: [activity], isLoading: false, message: '', activityIdToEdit: '1' };
const activityEdited: Status = { id: '1', status: 'active' };
const activityEdited: ActivityStatus = { id: '1', status: 'active' };
const expectedActivity: Activity = { id: '1', name: 'Training', description: 'It is good for learning', status: 'active' };
const action = new actions.UnarchiveActivitySuccess(activityEdited);
const state = activityManagementReducer(currentState, action);
Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/shared/models/activity.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export interface ActivityFront {
btnName: string;
}

export interface Status {
export interface ActivityStatus {
id: string;
status: string;
}