Skip to content

Conversation

@VanessaIniguez
Copy link
Collaborator

Create a general service for Feature Toggle and reused in different Components.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #667 (a0a179b) into master (13de42e) will increase coverage by 1.28%.
The diff coverage is 95.92%.

❗ Current head a0a179b differs from pull request most recent head e7bcb04. Consider uploading reports for the commit e7bcb04 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   93.09%   94.37%   +1.28%     
==========================================
  Files          85      104      +19     
  Lines        1564     1991     +427     
  Branches      107      139      +32     
==========================================
+ Hits         1456     1879     +423     
- Misses         67       73       +6     
+ Partials       41       39       -2     
Impacted Files Coverage Δ
...r-management/store/customer-management.reducers.ts 86.95% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
.../components/entry-fields/entry-fields.component.ts 93.15% <89.47%> (-6.85%) ⬇️
...app/modules/login/services/azure.ad.b2c.service.ts 80.00% <92.30%> (-2.36%) ⬇️
...les/shared/components/sidebar/sidebar.component.ts 90.62% <95.83%> (+1.73%) ⬆️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05fce31...e7bcb04. Read the comment docs.

Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job !! 🎊

@scastillo-jp scastillo-jp merged commit 757465d into master Apr 22, 2021
@scastillo-jp scastillo-jp deleted the TT-224-create-service-feature-toggle branch April 22, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants