Skip to content

Conversation

@LEON12699
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #662 (c571102) into master (13de42e) will increase coverage by 1.37%.
The diff coverage is 96.56%.

❗ Current head c571102 differs from pull request most recent head e536584. Consider uploading reports for the commit e536584 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   93.09%   94.47%   +1.37%     
==========================================
  Files          85      102      +17     
  Lines        1564     1972     +408     
  Branches      107      137      +30     
==========================================
+ Hits         1456     1863     +407     
- Misses         67       71       +4     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
...r-management/store/customer-management.reducers.ts 86.95% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 80.00% <92.30%> (-2.36%) ⬇️
...ponents/details-fields/details-fields.component.ts 94.00% <95.45%> (+6.82%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 90.62% <95.83%> (+1.73%) ⬆️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa91aa...e536584. Read the comment docs.

@LEON12699 LEON12699 requested a review from scastillo-jp April 14, 2021 20:42
Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job !

@scastillo-jp scastillo-jp merged commit c1c3eca into master Apr 16, 2021
@scastillo-jp scastillo-jp deleted the TT-29-Clean-Form-if-customer-is-removed branch April 16, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants