Skip to content

Conversation

LEON12699
Copy link
Member

@LEON12699 LEON12699 commented Apr 9, 2021

Add form reset icon in (timeEntries)
iconoReset

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #660 (821c7f0) into master (13de42e) will increase coverage by 1.42%.
The diff coverage is 96.58%.

❗ Current head 821c7f0 differs from pull request most recent head 5daa544. Consider uploading reports for the commit 5daa544 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   93.09%   94.52%   +1.42%     
==========================================
  Files          85      102      +17     
  Lines        1564     1954     +390     
  Branches      107      134      +27     
==========================================
+ Hits         1456     1847     +391     
- Misses         67       70       +3     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 84.00% <92.30%> (+1.64%) ⬆️
...ponents/details-fields/details-fields.component.ts 94.00% <95.45%> (+6.82%) ⬆️
src/app/modules/users/store/user.reducers.ts 96.55% <96.55%> (ø)
src/app/app-routing.module.ts 100.00% <100.00%> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d526a...5daa544. Read the comment docs.

@@ -167,6 +172,10 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
});
}

cleanFormWithSkipProject(): void {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this function to cleanFieldsForm.

@@ -64,13 +64,17 @@
<div class="modal-content" cdkDrag (cdkDragEnded)="resetDraggablePosition($event)">
<div class="modal-header" cdkDragHandle>
<h5 class="modal-title">{{ entryId ? 'Edit Entry' : 'New Entry' }}</h5>
<button type="button" class="btn" (click)="detailsFields.cleanFormWithSkipProject()">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How work with #Id detailsFields?
I think this should be this.cleanFormWithSkipProject()

Copy link
Member Author

@LEON12699 LEON12699 Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the #detailFields a local template variable associated with the app-details-fields component is created, this allows access to the functions and data of the app-details-fields component (child component) in this case when you click on the icon, the function cleanFormWithSkipProject() that is in the details-fields.component.ts is executed as it is not a function of the component time-entries.component.ts can not be accessed with this, but otherwise this.detailsFields.cleanFormWithSkipProject() can be used.

@LEON12699 LEON12699 requested a review from scastillo-jp April 9, 2021 20:03
@scastillo-jp scastillo-jp merged commit cb1a5c5 into master Apr 12, 2021
@scastillo-jp scastillo-jp deleted the TT-23-Clear-form-adding-an-entry branch April 12, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants