Skip to content

Conversation

@thegreatyamori
Copy link
Collaborator

  • Added ngrx-store-localstorage to persist specific store (user)
  • Added Feature Toggle switch-group to mantain the old logic
  • Added the corresponding tests

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #658 (7db46c9) into master (13de42e) will increase coverage by 1.23%.
The diff coverage is 96.45%.

❗ Current head 7db46c9 differs from pull request most recent head 1f82410. Consider uploading reports for the commit 1f82410 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   93.09%   94.32%   +1.23%     
==========================================
  Files          85      102      +17     
  Lines        1564     1940     +376     
  Branches      107      129      +22     
==========================================
+ Hits         1456     1830     +374     
- Misses         67       72       +5     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 84.00% <92.30%> (+1.64%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
src/app/modules/users/store/user.reducers.ts 96.55% <96.55%> (ø)
src/app/app-routing.module.ts 100.00% <100.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec9ce0...1f82410. Read the comment docs.

@scastillo-jp scastillo-jp merged commit 647de5a into master Apr 7, 2021
@scastillo-jp scastillo-jp deleted the TT-189-use-user-info-service-to-check-if-user-is-admin-in-UI branch April 7, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants