Skip to content

Conversation

LEON12699
Copy link
Member

Feature that change logic of grant/revoke roles to add/remove group , under FT 'switch-group'

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #654 (8b835f0) into master (13de42e) will increase coverage by 1.13%.
The diff coverage is 96.23%.

❗ Current head 8b835f0 differs from pull request most recent head f86f473. Consider uploading reports for the commit f86f473 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   93.09%   94.22%   +1.13%     
==========================================
  Files          85      101      +16     
  Lines        1564     1922     +358     
  Branches      107      127      +20     
==========================================
+ Hits         1456     1811     +355     
- Misses         67       72       +5     
+ Partials       41       39       -2     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 71.42% <71.42%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 83.33% <91.66%> (+0.98%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
src/app/modules/users/store/user.reducers.ts 96.55% <96.55%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14945aa...f86f473. Read the comment docs.

Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job guys !

@LEON12699 LEON12699 force-pushed the TT-190-Use-add-remove-groups-endpoints-users branch from 9579165 to d614213 Compare March 30, 2021 20:46
@LEON12699 LEON12699 force-pushed the TT-190-Use-add-remove-groups-endpoints-users branch from d614213 to f86f473 Compare March 30, 2021 21:11
@scastillo-jp scastillo-jp merged commit 03ff558 into master Mar 31, 2021
@scastillo-jp scastillo-jp deleted the TT-190-Use-add-remove-groups-endpoints-users branch March 31, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants