Skip to content

Conversation

thegreatyamori
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #653 (e5356d1) into master (13de42e) will increase coverage by 1.13%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
+ Coverage   93.09%   94.23%   +1.13%     
==========================================
  Files          85      101      +16     
  Lines        1564     1907     +343     
  Branches      107      125      +18     
==========================================
+ Hits         1456     1797     +341     
- Misses         67       72       +5     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 93.75% <ø> (+1.64%) ⬆️
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 71.42% <71.42%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 83.33% <91.66%> (+0.98%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82a479...e5356d1. Read the comment docs.

Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job. I think we would need to update the references in all the files:
add group to user to add user to group and
remove group to user to remove user from group.

@thegreatyamori
Copy link
Collaborator Author

Very good job. I think we would need to update the references in all the files:
add group to user to add user to group and
remove group to user to remove user from group.

ok, I'm going to change the references

@scastillo-jp scastillo-jp merged commit ef60e47 into master Mar 29, 2021
@scastillo-jp scastillo-jp deleted the TT-188-add-and-remove-users-from-groups branch March 29, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants