-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-178 Make URI clickable when possible #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/app/modules/reports/components/time-entries-table/time-entries-table.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Only some fixes. Also, before applying changes, make sure to rebase your branch with master, as you have some conflicts.
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
074b80b
to
2782895
Compare
2782895
to
da18ee9
Compare
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
+ Coverage 93.09% 94.21% +1.12%
==========================================
Files 85 95 +10
Lines 1564 1798 +234
Branches 107 120 +13
==========================================
+ Hits 1456 1694 +238
- Misses 67 68 +1
+ Partials 41 36 -5
Continue to review full report at Codecov.
|
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.html
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Show resolved
Hide resolved
src/app/modules/reports/components/time-entries-table/time-entries-table.component.ts
Outdated
Show resolved
Hide resolved
Good work, only remains to correct the type of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!.
make uri clickable when possible