Skip to content

Conversation

wobravo
Copy link
Contributor

@wobravo wobravo commented Mar 18, 2021

make uri clickable when possible

Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Only some fixes. Also, before applying changes, make sure to rebase your branch with master, as you have some conflicts.

@wobravo wobravo force-pushed the TT-178-Make-URI-clickable-when-possible branch from 074b80b to 2782895 Compare March 19, 2021 16:27
@wobravo wobravo force-pushed the TT-178-Make-URI-clickable-when-possible branch from 2782895 to da18ee9 Compare March 19, 2021 16:32
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #649 (545bdc0) into master (13de42e) will increase coverage by 1.12%.
The diff coverage is 96.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   93.09%   94.21%   +1.12%     
==========================================
  Files          85       95      +10     
  Lines        1564     1798     +234     
  Branches      107      120      +13     
==========================================
+ Hits         1456     1694     +238     
- Misses         67       68       +1     
+ Partials       41       36       -5     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ccc1f...545bdc0. Read the comment docs.

@thegreatyamori
Copy link
Collaborator

Good work, only remains to correct the type of the isURL function.

Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!.

@scastillo-jp scastillo-jp merged commit 77ce5e7 into master Mar 19, 2021
@scastillo-jp scastillo-jp deleted the TT-178-Make-URI-clickable-when-possible branch March 19, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants