Skip to content

Conversation

@eduardisrael
Copy link
Contributor

add @angular/cdk and a unit test

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #646 (b383354) into master (13de42e) will increase coverage by 1.11%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   93.09%   94.20%   +1.11%     
==========================================
  Files          85       95      +10     
  Lines        1564     1795     +231     
  Branches      107      119      +12     
==========================================
+ Hits         1456     1691     +235     
+ Misses         67       66       -1     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 55.55% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118e0d1...258be2b. Read the comment docs.

@thegreatyamori
Copy link
Collaborator

@eduardisrael a question.
The panel moves freely or is the movement restricted as here?
https://material.angular.io/cdk/drag-drop/overview#restricting-movement-within-an-element

@kellycastrof
Copy link

@eduardisrael a question.
The panel moves freely or is the movement restricted as here?
https://material.angular.io/cdk/drag-drop/overview#restricting-movement-within-an-element

It is not restricted but if you drop it returns to the initial site.

@eduardisrael eduardisrael merged commit eeb2e6a into master Mar 15, 2021
@eduardisrael eduardisrael deleted the TT-35-Entries-creation-modal-panel-draggable branch March 15, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants