Skip to content

Conversation

VanessaIniguez
Copy link
Collaborator

Add the parameters startDate and endDate in the path used by the findEntriesByProjectId method of the EntryService service.

… by the findEntriesProjectId method of the EntryService service
@israteneda
Copy link
Contributor

A test seems to be failing 🤔

@kellycastrof
Copy link

Yes, but locally the tests were successful.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #644 (04cc5f1) into master (13de42e) will increase coverage by 1.10%.
The diff coverage is 97.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   93.09%   94.20%   +1.10%     
==========================================
  Files          85       95      +10     
  Lines        1564     1794     +230     
  Branches      107      119      +12     
==========================================
+ Hits         1456     1690     +234     
  Misses         67       67              
+ Partials       41       37       -4     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 55.55% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.13% <81.81%> (+2.32%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.54% <94.44%> (+6.36%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78badb...44aa752. Read the comment docs.

@VanessaIniguez VanessaIniguez merged commit 210d2dd into master Mar 11, 2021
@VanessaIniguez VanessaIniguez deleted the TT-168-load-last-entries-first-day branch March 11, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants