Skip to content

Conversation

@wobravo
Copy link
Contributor

@wobravo wobravo commented Feb 23, 2021

feature to update the date out when editing the date in.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #640 (7c0b51f) into master (13de42e) will increase coverage by 1.13%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   93.09%   94.22%   +1.13%     
==========================================
  Files          85       95      +10     
  Lines        1564     1785     +221     
  Branches      107      118      +11     
==========================================
+ Hits         1456     1682     +226     
+ Misses         67       65       -2     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 55.55% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <76.47%> (+1.47%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.47% <94.11%> (+6.29%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d593c8...7c0b51f. Read the comment docs.

expect(component.projectSelected.emit).toHaveBeenCalledWith(data);
});

it('on Selected Initial Date should change end date', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical. But we can use Start date reference instead of initial date

@wobravo wobravo changed the title Tt 149 when edit date in update the date out TT 149 when edit date in update the date out Feb 23, 2021
@wobravo wobravo changed the title TT 149 when edit date in update the date out fix: TT 149 when edit date in update the date out Feb 23, 2021
@wobravo wobravo requested a review from Angeluz-07 February 23, 2021 17:59
@wobravo wobravo requested a review from josepato87 February 23, 2021 18:57
@wobravo wobravo self-assigned this Feb 24, 2021
@scastillo-jp scastillo-jp force-pushed the TT-149-When-edit-Date-In-update-the-Date-Out branch from 63b6e91 to 76e4ff5 Compare February 24, 2021 21:50
@scastillo-jp scastillo-jp force-pushed the TT-149-When-edit-Date-In-update-the-Date-Out branch from 76e4ff5 to 7c0b51f Compare February 24, 2021 21:58
@scastillo-jp scastillo-jp merged commit 414c4a6 into master Feb 24, 2021
@scastillo-jp scastillo-jp deleted the TT-149-When-edit-Date-In-update-the-Date-Out branch February 24, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants