-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-141 Have the data persistent in the modal #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 93.09% 94.24% +1.14%
==========================================
Files 85 95 +10
Lines 1564 1789 +225
Branches 107 119 +12
==========================================
+ Hits 1456 1686 +230
+ Misses 67 65 -2
+ Partials 41 38 -3
Continue to review full report at Codecov.
|
scastillo-jp
approved these changes
Feb 24, 2021
…her it is a new entry or an existing one and persist the data in the form, create their respective tests
Angeluz-07
reviewed
Feb 25, 2021
Angeluz-07
reviewed
Feb 25, 2021
src/app/modules/shared/components/details-fields/details-fields.component.ts
Show resolved
Hide resolved
Angeluz-07
reviewed
Feb 25, 2021
Angeluz-07
reviewed
Feb 25, 2021
Angeluz-07
approved these changes
Feb 26, 2021
israteneda
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the data persist in the modal when the modal is closed.