Skip to content

Conversation

@LEON12699
Copy link
Member

It is necessary to choose project to enter the data

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #636 (5f20f8a) into master (13de42e) will increase coverage by 1.11%.
The diff coverage is 98.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   93.09%   94.20%   +1.11%     
==========================================
  Files          85       95      +10     
  Lines        1564     1778     +214     
  Branches      107      118      +11     
==========================================
+ Hits         1456     1675     +219     
+ Misses         67       65       -2     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.40% <93.93%> (+6.22%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d467356...4133133. Read the comment docs.

@LEON12699 LEON12699 self-assigned this Feb 3, 2021
@scastillo-jp
Copy link
Collaborator

@here this change looks good, lost if project is selected at last, good job @israel León Gálvez @william Bravo TT-140 time entry info is
Just one change adds a border radius at the input for the entry / exit time. so that everything looks similar.
Screen Shot 2021-02-05 at 11 45 54 AM

@scastillo-jp scastillo-jp self-requested a review February 5, 2021 16:58
@LEON12699 LEON12699 force-pushed the TT-140-Time-entry-info-lost branch from ce2e364 to 5520d1d Compare February 5, 2021 23:51
@LEON12699 LEON12699 force-pushed the TT-140-Time-entry-info-lost branch from 35fc482 to 997af76 Compare February 6, 2021 00:02
@LEON12699 LEON12699 requested a review from Angeluz-07 February 6, 2021 02:26
@LEON12699 LEON12699 requested a review from Angeluz-07 February 8, 2021 19:26
Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

@scastillo-jp scastillo-jp merged commit 89a20ca into master Feb 8, 2021
@scastillo-jp scastillo-jp deleted the TT-140-Time-entry-info-lost branch February 8, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants