Skip to content

Conversation

@jr-98
Copy link
Contributor

@jr-98 jr-98 commented Feb 2, 2021

All tables are now responsive

@jr-98 jr-98 self-assigned this Feb 2, 2021
@juanultimate juanultimate self-requested a review February 3, 2021 03:01
@juanultimate juanultimate self-requested a review February 3, 2021 15:02
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #635 (58b5dc6) into master (13de42e) will increase coverage by 1.13%.
The diff coverage is 97.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   93.09%   94.22%   +1.13%     
==========================================
  Files          85       95      +10     
  Lines        1564     1784     +220     
  Branches      107      118      +11     
==========================================
+ Hits         1456     1681     +225     
+ Misses         67       65       -2     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 55.55% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <76.47%> (+1.47%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.40% <93.93%> (+6.22%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5773d7...58b5dc6. Read the comment docs.

@jr-98 jr-98 requested a review from scastillo-jp February 3, 2021 20:31
@scastillo-jp
Copy link
Collaborator

@jr-98
I found this problem when the data is loading
Screen Shot 2021-02-05 at 11 12 25 AM

After loading the data, the table does not have the correct margin:
Screen Shot 2021-02-05 at 11 12 34 AM

@scastillo-jp scastillo-jp self-requested a review February 5, 2021 16:17
@jr-98 jr-98 force-pushed the TT-144-Responsive-All-Tables branch from 91686d7 to af8270a Compare February 10, 2021 00:27
@scastillo-jp scastillo-jp force-pushed the TT-144-Responsive-All-Tables branch from af8270a to 58b5dc6 Compare February 18, 2021 20:59
@scastillo-jp
Copy link
Collaborator

Uploading Screen Recording 2021-02-18 at 3.56.46 PM.mov…

@scastillo-jp scastillo-jp merged commit e735f5e into master Feb 18, 2021
@scastillo-jp scastillo-jp deleted the TT-144-Responsive-All-Tables branch February 18, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants