Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ describe('UsersListComponent', () => {
{
name: 'name',
email: 'email',
role: null,
roles: ['admin', 'test'],
id: 'id',
tenant_id: 'tenant id',
Expand Down Expand Up @@ -111,7 +110,7 @@ describe('UsersListComponent', () => {
});
});

it('on success load users, the data of roles should be an array and role null', () => {
it('on success load users, the data of roles should be an array', () => {
const actionSubject = TestBed.inject(ActionsSubject) as ActionsSubject;
const action = {
type: UserActionTypes.LOAD_USERS_SUCCESS,
Expand All @@ -121,41 +120,10 @@ describe('UsersListComponent', () => {
actionSubject.next(action);

component.users.map((user) => {
expect(user.role).toEqual(null);
expect(user.roles).toEqual(['admin', 'test']);
});
});

it('on success load users, the data of roles should be null and role a string', () => {
const actionSubject = TestBed.inject(ActionsSubject) as ActionsSubject;
const mockState: UserState = {
data: [
{
name: 'name',
email: 'email',
role: 'admin',
roles: null,
id: 'id',
tenant_id: 'tenant id',
deleted: 'delete',
},
],
isLoading: false,
message: '',
};
const action = {
type: UserActionTypes.LOAD_USERS_SUCCESS,
payload: mockState.data,
};

actionSubject.next(action);

component.users.map((user) => {
expect(user.role).toEqual('admin');
expect(user.roles).toEqual(null);
});
});

it('on success load users, the datatable should be reloaded', async () => {
const actionSubject = TestBed.inject(ActionsSubject);
const action = {
Expand Down
1 change: 0 additions & 1 deletion src/app/modules/users/models/users.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export interface User {
name: string;
email: string;
role?: string;
roles?: string[];
id: string;
tenant_id?: string;
Expand Down
12 changes: 6 additions & 6 deletions src/app/modules/users/store/user.reducer.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ describe('userReducer', () => {
expect(state.isLoading).toEqual(true);
});

it('on GrantRoleUserSuccess, user role should change', () => {
it('on GrantRoleUserSuccess, user roles should change', () => {
const currentState: UserState = {
data: [{ id: 'id', name: 'name', email: 'email', role: null }],
data: [{ id: 'id', name: 'name', email: 'email', roles: null }],
isLoading: false,
message: '',
};
const userGranted: User = { id: 'id', name: 'name', email: 'email', role: 'admin' };
const userGranted: User = { id: 'id', name: 'name', email: 'email', roles: ['admin'] };
const action = new actions.GrantRoleUserSuccess(userGranted);
const state = userReducer(currentState, action);

Expand All @@ -70,13 +70,13 @@ describe('userReducer', () => {
expect(state.isLoading).toEqual(true);
});

it('on RevokeRoleUserSuccess, user role should change', () => {
it('on RevokeRoleUserSuccess, user roles should change', () => {
const currentState: UserState = {
data: [{ id: 'id', name: 'name', email: 'email', role: 'admin' }],
data: [{ id: 'id', name: 'name', email: 'email', roles: ['admin'] }],
isLoading: false,
message: '',
};
const userRevoked: User = { id: 'id', name: 'name', email: 'email', role: null };
const userRevoked: User = { id: 'id', name: 'name', email: 'email', roles: null };
const action = new actions.RevokeRoleUserSuccess(userRevoked);
const state = userReducer(currentState, action);

Expand Down