Skip to content

Conversation

@jr-98
Copy link
Contributor

@jr-98 jr-98 commented Jan 27, 2021

Margin left is done. Additionally I corrected the problem of resposivity in the header of the customer table.

@jr-98 jr-98 self-assigned this Jan 27, 2021
@jr-98 jr-98 force-pushed the TT-139-Reduce-the-left-margin-on-the-customer-page branch from 223e38a to 8773695 Compare January 28, 2021 02:55
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #631 (a50fda4) into master (13de42e) will increase coverage by 1.20%.
The diff coverage is 99.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
+ Coverage   93.09%   94.30%   +1.20%     
==========================================
  Files          85       95      +10     
  Lines        1564     1773     +209     
  Branches      107      116       +9     
==========================================
+ Hits         1456     1672     +216     
+ Misses         67       63       -4     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 92.10% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4064ca...0a4c244. Read the comment docs.

@jr-98 jr-98 assigned jr-98 and Marvin-Valdivieso and unassigned jr-98 Jan 28, 2021
@jr-98 jr-98 force-pushed the TT-139-Reduce-the-left-margin-on-the-customer-page branch from 8773695 to 91281fb Compare January 28, 2021 03:28
Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to rebase with master. So tests can pass and also to have your branch updated.

@jr-98 jr-98 force-pushed the TT-139-Reduce-the-left-margin-on-the-customer-page branch from 91281fb to b0a9190 Compare January 29, 2021 01:26
@jr-98 jr-98 requested review from Angeluz-07 and scastillo-jp and removed request for PaulRC-ioet, enriquezrene and juanultimate January 29, 2021 01:37
@juanultimate juanultimate changed the title fix: TT-139 Reduce the left margin on coutome page fix: TT-139 Reduce the left margin on customers page Jan 29, 2021
@juanultimate
Copy link
Contributor

juanultimate commented Jan 29, 2021

Not sure why you have three commits for this PR. IMHO, one commit is enough, or at least you can squash these two commits
image

@josepato87
Copy link
Contributor

Not sure why you have three commits for this PR. IIMHO, one commit is enough, or at least you can squash these two commits
image

@juanultimate He asked me about those commits, I suggested to leave them as it, but when merging we would squash this PR. Besides, I suggested to put better names in his commits, because it's useful to see the whole history of changes when reviewing the code.

@scastillo-jp scastillo-jp force-pushed the TT-139-Reduce-the-left-margin-on-the-customer-page branch from b0a9190 to 0a4c244 Compare January 29, 2021 17:12
@scastillo-jp scastillo-jp merged commit 691bf66 into master Jan 29, 2021
@scastillo-jp scastillo-jp deleted the TT-139-Reduce-the-left-margin-on-the-customer-page branch January 29, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants