fix: TT-125 show customer field in time entries table #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israteneda
requested review from
scastillo-jp,
Angeluz-07,
josepato87 and
PaulRC-ioet
|
Good job!! |
juanultimate
approved these changes
Jan 22, 2021
|
Tests are failing. It seems https://ioetec.atlassian.net/browse/TT-129 must be your P1 |
josepato87
reviewed
Jan 22, 2021
Comment on lines
+380
to
+386
| description: 'testing is fun', | ||
| technologies: [], | ||
| uri: 'http://testing.is.fun', | ||
| activity_id: 'sss', | ||
| project_id: 'id', | ||
| start_date: new Date(new Date().setHours(0, 0, 0, 0)), | ||
| end_date: new Date(new Date().setHours(0, 0, 0, 0)) |
israteneda
force-pushed
the
TT-125-show-customer-field
branch
from
fe24d64 to
7553dd6
Compare
josepato87
approved these changes
Jan 22, 2021
| const entryData = dataSource.data[0]; | ||
|
|
||
| expect(entryData.customer_name).toContain('ioet Inc.'); | ||
|
|
There was a problem hiding this comment.
delete this line in blank
| }); | ||
|
|
||
| expect(expectedColumnTitles).toEqual(columnTitles); | ||
|
|
There was a problem hiding this comment.
delete this line in blank
|
|
||
| }); | ||
| })); | ||
|
|
There was a problem hiding this comment.
delete this line in blank
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 93.09% 93.90% +0.81%
==========================================
Files 85 95 +10
Lines 1564 1772 +208
Branches 107 116 +9
==========================================
+ Hits 1456 1664 +208
- Misses 67 69 +2
+ Partials 41 39 -2
Continue to review full report at Codecov.
|
scastillo-jp
approved these changes
Jan 25, 2021
israteneda
force-pushed
the
TT-125-show-customer-field
branch
from
afd1e5d to
d401dd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.