-
Notifications
You must be signed in to change notification settings - Fork 1
Tt 117 two entries in progress bug #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 93.09% 94.30% +1.20%
==========================================
Files 85 95 +10
Lines 1564 1773 +209
Branches 107 116 +9
==========================================
+ Hits 1456 1672 +216
+ Misses 67 64 -3
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
a485ada
to
4de39db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that creating tests scenarios for active entries and other entries should work better.
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
b1fb662
to
498639b
Compare
6c5753f
to
f248a16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a comment regarding missing test
src/app/modules/shared/components/details-fields/details-fields.component.ts
Show resolved
Hide resolved
src/app/modules/shared/components/details-fields/details-fields.component.spec.ts
Show resolved
Hide resolved
ff542bc
to
cbf454c
Compare
No description provided.