Skip to content

Conversation

scastillo-jp
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #627 (cbf454c) into master (13de42e) will increase coverage by 1.20%.
The diff coverage is 99.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   93.09%   94.30%   +1.20%     
==========================================
  Files          85       95      +10     
  Lines        1564     1773     +209     
  Branches      107      116       +9     
==========================================
+ Hits         1456     1672     +216     
+ Misses         67       64       -3     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 95.50% <100.00%> (+8.32%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72fd55...cbf454c. Read the comment docs.

@scastillo-jp scastillo-jp force-pushed the TT-117-two-entries-in-progress-bug branch from a485ada to 4de39db Compare January 20, 2021 17:44
Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that creating tests scenarios for active entries and other entries should work better.

@scastillo-jp scastillo-jp force-pushed the TT-117-two-entries-in-progress-bug branch 3 times, most recently from b1fb662 to 498639b Compare January 27, 2021 17:44
@scastillo-jp scastillo-jp self-assigned this Jan 27, 2021
@scastillo-jp scastillo-jp force-pushed the TT-117-two-entries-in-progress-bug branch 3 times, most recently from 6c5753f to f248a16 Compare January 28, 2021 20:09
Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a comment regarding missing test

@scastillo-jp scastillo-jp force-pushed the TT-117-two-entries-in-progress-bug branch from ff542bc to cbf454c Compare January 29, 2021 15:02
@scastillo-jp scastillo-jp merged commit ab27add into master Jan 29, 2021
@scastillo-jp scastillo-jp deleted the TT-117-two-entries-in-progress-bug branch January 29, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants