Skip to content

Conversation

PaulRC-ioet
Copy link
Contributor

Add a user Roles field in the model User

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #614 (2767e33) into master (13de42e) will increase coverage by 0.92%.
The diff coverage is 99.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   93.09%   94.01%   +0.92%     
==========================================
  Files          85       95      +10     
  Lines        1564     1722     +158     
  Branches      107      115       +8     
==========================================
+ Hits         1456     1619     +163     
+ Misses         67       63       -4     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.18% <100.00%> (+6.00%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efe61b...2767e33. Read the comment docs.

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing, testing please

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some quick solving comments

@josepato87 josepato87 requested a review from israteneda January 14, 2021 23:04
@israteneda israteneda merged commit 8058078 into master Jan 15, 2021
@israteneda israteneda deleted the TT-111-ChangeModelUsers branch January 15, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants