#3-Time clock find project #61
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| component.changeFilterProject.emit('angular'); | ||
| component.filterProject = 'angular'; | ||
| component.changeFilterValue(); | ||
| expect(component.filterProject).toEqual('angular'); |
There was a problem hiding this comment.
I think that is not a good test because you are assigning the value in the variable and after you wait that your expect has that value.
You should test that emit has been called, you can is that example in project-list test.
| }); | ||
|
|
||
| it('test method of pipe', () => { | ||
| expect(new FilterProjectPipe().transform([], '')).toEqual([]); |
There was a problem hiding this comment.
improve the test, you can create a mock with projects data and test the transform method.
| { | ||
| "id": 3, | ||
| "name": "Facebook", | ||
| "details": "It's a good app to play Lottery", |
There was a problem hiding this comment.
change the detail, please :)
macrisguncay
reviewed
Apr 1, 2020
| "@angular-devkit/build-angular": "^0.900.5", | ||
| "@angular/cli": "~9.0.4", | ||
| "@angular-devkit/build-angular": "^0.901.0", | ||
| "@angular/cli": "^9.1.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR remplaza al anterior ya que hubo conflictos con la nueva estructura.
Se ha añadido el buscador tanto en Time Clock y Projects.
Se ha usado el servicio ProjectService para poblar la lista de proyectos activos en la vista de Time Clock.