Skip to content

TT-107 feat: Limit the year selector in UI to the current year #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 7, 2021
Merged

TT-107 feat: Limit the year selector in UI to the current year #604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
743c2af
TT-107 feat: Limit the year selector in UI to the current year
scastillo-jp Jan 5, 2021
32894ef
TT-107 fix: code cov
scastillo-jp Jan 5, 2021
c51e9d2
TT-107 fix: resolve comments
scastillo-jp Jan 5, 2021
1b7ebe6
TT-107 fix: order variables
scastillo-jp Jan 5, 2021
6209d10
TT-107 fix: resolve a comment
scastillo-jp Jan 5, 2021
ebf99e9
TT-107 fix: improve changes
scastillo-jp Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
TT-107 fix: improve changes
  • Loading branch information
@scastillo-jp
scastillo-jp committed Jan 6, 2021
commit ebf99e90c2d35010716fd5e500fb782d2bfc8878
15 changes: 8 additions & 7 deletions src/app/modules/shared/components/month-picker/month-picker.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
<div class="card-header">
<div class="row align-items-center">
<div class="col-sm-4">
<div class="row">
<div class="col-4">
<button class="btn mr-auto" (click)="changeYear('subtract')">
<i class="fa fa-chevron-left"></i>
</button>
</div>
<div class="col-sm-4">
<p class="text-center year-text">

<div class="col-4 align-item">
<p class="year-text">
{{selectedYearText}}
</p>
</div>

<div class="col-sm-4 text-right">
<button *ngIf="showArrowNext" class="btn ml-auto" (click)="changeYear('add')">
<div class="col-4 text-right">
<button class="btn ml-auto" *ngIf="showArrowNext" (click)="changeYear('add')">
<i class="fa fa-chevron-right"></i>
</button>
</div>
</div>
</div>
<div class="row content-months">
<div class="spacing col-xl-1 col-lg-1 col-md-2 col-sm-2 col-xs-4" *ngFor="let month of months; let i = index">
<div class="spacing col-xl-1 col-lg-1 col-md-2 col-2" *ngFor="let month of months; let i = index">
<button class="btn btn-light btn-block"
[ngClass]="{'btn-primary': isSelectedMonth(i)}"
(click)="selectMonth(i)">
Expand Down
5 changes: 5 additions & 0 deletions src/app/modules/shared/components/month-picker/month-picker.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
}
}

.align-item {
display: flex;
justify-content: center;
align-items: center;
}
.active {
@include highlight();
border-radius: 0.2em;
Expand Down
3 changes: 2 additions & 1 deletion src/app/modules/shared/components/month-picker/month-picker.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('MonthPickerComponent', () => {
expect(component.changeYear).toHaveBeenCalled();
expect(component.selectedYearText).toEqual(incrementYear);
expect(component.selectedYearMoment.format('Y')).toEqual(incrementYear);
expect(component.showArrowNext).toEqual(false);
expect(component.showArrowNext).toBe(false, 'false to hidden arrow next in current year');
});

it('should subtract a year to current year', () => {
Expand All @@ -56,6 +56,7 @@ describe('MonthPickerComponent', () => {

expect(component.changeYear).toHaveBeenCalled();
expect(component.selectedYearMoment.format('Y')).toEqual(decrementYear);
expect(component.showArrowNext).toBe(true, 'true to show arrow next in previous years');
});

it('selectMonth should call selectDate', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/shared/components/month-picker/month-picker.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export class MonthPickerComponent implements OnInit {
const monthIndex = changeAction === 'add' ? 0 : 11;
this.selectMonth(monthIndex);

this.showArrowNext = this.selectedYear < this.currentYear ?? true;
this.showArrowNext = this.selectedYear < this.currentYear;
}

selectMonth(monthIndex: number) {
Expand Down