Skip to content

Conversation

daros10
Copy link
Contributor

@daros10 daros10 commented Mar 10, 2020

template TSheet

seconds: number;

constructor() {
this.currentState = new Date();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currentDate?

Comment on lines 21 to 22
console.log(this.hour, this.minutes, this.seconds);
console.log(this.currentState);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these lines useful somehow?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not, go ahead and remove them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

<!-- Sidebar -->
<div class="bg-light border-right" id="sidebar-wrapper">
<div class="list-group list-group-flush">
<a href="#" class="list-group-item list-group-item-action bg-light"><i class="fas fa-flag"></i> Getting Started</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not having a css file with a class containing all these styles?
class="list-group-item list-group-item-action bg-light"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are own bootstrap classes

@@ -1,6 +1,6 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A README file with the instructions to run the app would be great.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular cli automatically generates information on how to lift the project

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, all the content of time-tracker must be moved to the time-tracker-ui directory.
cc: @macrisguncay @daros10

@daros10 daros10 changed the title basic template TSheet home screen TSheet Mar 11, 2020
@enriquezrene enriquezrene merged commit e4d26ce into master Mar 12, 2020
@enriquezrene enriquezrene deleted the TSheets-UI branch March 12, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants