-
Notifications
You must be signed in to change notification settings - Fork 1
home screen TSheet #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
seconds: number; | ||
|
||
constructor() { | ||
this.currentState = new Date(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currentDate?
console.log(this.hour, this.minutes, this.seconds); | ||
console.log(this.currentState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these lines useful somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, go ahead and remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
<!-- Sidebar --> | ||
<div class="bg-light border-right" id="sidebar-wrapper"> | ||
<div class="list-group list-group-flush"> | ||
<a href="#" class="list-group-item list-group-item-action bg-light"><i class="fas fa-flag"></i> Getting Started</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not having a css file with a class containing all these styles?
class="list-group-item list-group-item-action bg-light"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are own bootstrap classes
time-tracker/angular.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A README file with the instructions to run the app would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
angular cli automatically generates information on how to lift the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, all the content of time-tracker must be moved to the time-tracker-ui directory.
cc: @macrisguncay @daros10
template TSheet