Skip to content

Conversation

gqroot
Copy link

@gqroot gqroot commented Dec 30, 2020

No description provided.

@gqroot gqroot force-pushed the TT-39-default-month-when-changing-year branch from 071bd2e to be2dcbe Compare December 30, 2020 00:24
@gqroot gqroot force-pushed the TT-39-default-month-when-changing-year branch from be2dcbe to 0b0e66e Compare December 30, 2020 00:26
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #596 (d54d6de) into master (13de42e) will increase coverage by 0.62%.
The diff coverage is 99.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
+ Coverage   93.09%   93.71%   +0.62%     
==========================================
  Files          85       95      +10     
  Lines        1564     1719     +155     
  Branches      107      114       +7     
==========================================
+ Hits         1456     1611     +155     
- Misses         67       69       +2     
+ Partials       41       39       -2     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 93.18% <100.00%> (+6.00%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62227a6...d54d6de. Read the comment docs.

Copy link
Contributor

@PaulRC-ioet PaulRC-ioet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good way to refactor the code, in my opinion, everything is fine.

@gqroot gqroot merged commit 2d8b1e2 into master Dec 30, 2020
@gqroot gqroot deleted the TT-39-default-month-when-changing-year branch December 30, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants