Skip to content

Conversation

josepato87
Copy link
Contributor

There is a test missing. Looking at some documentation we need something else (Test/Wrapper Component) to test the whole feature of the 'goingToWorkOnThis'. This could be done in tech debt :(. Not a clean solution, but regarding time, it's enough.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #594 (ecdc420) into master (13de42e) will increase coverage by 0.67%.
The diff coverage is 98.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   93.09%   93.77%   +0.67%     
==========================================
  Files          85       95      +10     
  Lines        1564     1702     +138     
  Branches      107      112       +5     
==========================================
+ Hits         1456     1596     +140     
- Misses         67       68       +1     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 83.58% <87.50%> (+0.76%) ⬆️
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
...ponents/details-fields/details-fields.component.ts 90.90% <96.66%> (+3.72%) ⬆️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df0ae39...ecdc420. Read the comment docs.

@josepato87 josepato87 merged commit d2a4d5f into master Dec 28, 2020
@josepato87 josepato87 deleted the TT-52-date-out-should-be-the-same-as-date-in branch December 28, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants