TT-85 fix: refactor code of time fields #593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josepato87
requested review from
Angeluz-07,
PaulRC-ioet,
gqroot and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 93.09% 93.76% +0.67%
==========================================
Files 85 95 +10
Lines 1564 1700 +136
Branches 107 112 +5
==========================================
+ Hits 1456 1594 +138
- Misses 67 69 +2
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
Angeluz-07
approved these changes
Dec 28, 2020
PaulRC-ioet
reviewed
Dec 28, 2020
| this.goingToWorkOnThis = event.currentTarget.checked; | ||
| if (!this.goingToWorkOnThis) { | ||
| this.entryForm.patchValue({ end_hour: formatDate(new Date(), 'HH:mm:ss', 'en') }); | ||
| this.entryForm.patchValue({ |
There was a problem hiding this comment.
There is an opportunity to improve our coverage, testing this line according to Codecov. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a test missing. Looking at some documentation we need something else (Test/Wrapper Component) to test the whole feature of the 'goingToWorkOnThis'. This could be done in tech debt :(. Not a clean solution, but regarding time, it's enough.