TT-64 fix: set technologies as list when create time-entry#592
Merged
Angeluz-07 merged 1 commit intomasterfrom Dec 21, 2020
Merged
TT-64 fix: set technologies as list when create time-entry#592Angeluz-07 merged 1 commit intomasterfrom
Angeluz-07 merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 93.09% 93.73% +0.63%
==========================================
Files 85 95 +10
Lines 1564 1691 +127
Branches 107 110 +3
==========================================
+ Hits 1456 1585 +129
- Misses 67 68 +1
+ Partials 41 38 -3
Continue to review full report at Codecov.
|
josepato87
approved these changes
Dec 21, 2020
Contributor
josepato87
left a comment
There was a problem hiding this comment.
LGTM, please don't forget that we have some tests pending :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, we ensure that at the moment the time-entry is created, the technologies field is set as an empty list. See TT-64 for details.