Skip to content

Conversation

@Angeluz-07
Copy link
Contributor

@Angeluz-07 Angeluz-07 commented Dec 21, 2020

With these changes, we ensure that at the moment the time-entry is created, the technologies field is set as an empty list. See TT-64 for details.

@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #592 (6752a75) into master (13de42e) will increase coverage by 0.63%.
The diff coverage is 99.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   93.09%   93.73%   +0.63%     
==========================================
  Files          85       95      +10     
  Lines        1564     1691     +127     
  Branches      107      110       +3     
==========================================
+ Hits         1456     1585     +129     
- Misses         67       68       +1     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
src/app/modules/time-clock/store/entry.effects.ts 96.26% <ø> (+0.42%) ⬆️
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 89.61% <100.00%> (+2.43%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb1516...6752a75. Read the comment docs.

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please don't forget that we have some tests pending :)

@Angeluz-07 Angeluz-07 merged commit 2e23d02 into master Dec 21, 2020
@Angeluz-07 Angeluz-07 deleted the TT64_allow_select_technologies branch December 21, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants