Skip to content

Conversation

@PaulRC-ioet
Copy link
Contributor

Fix bug when is updating two entries in order

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #589 (8fd8bff) into master (13de42e) will increase coverage by 0.69%.
The diff coverage is 98.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   93.09%   93.79%   +0.69%     
==========================================
  Files          85       95      +10     
  Lines        1564     1691     +127     
  Branches      107      110       +3     
==========================================
+ Hits         1456     1586     +130     
  Misses         67       67              
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 83.58% <87.50%> (+0.76%) ⬆️
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 89.61% <100.00%> (+2.43%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 92.00% <100.00%> (+3.11%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb1516...8fd8bff. Read the comment docs.

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, most of them are regarding context naming, and some missing coverage.

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulRC-ioet PaulRC-ioet merged commit 06f895a into master Dec 17, 2020
@PaulRC-ioet PaulRC-ioet deleted the TT-70FixUpdateTwoEntries branch December 17, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants