-
Notifications
You must be signed in to change notification settings - Fork 1
TT-70 fix: fix bug when update two entries #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 93.09% 93.79% +0.69%
==========================================
Files 85 95 +10
Lines 1564 1691 +127
Branches 107 110 +3
==========================================
+ Hits 1456 1586 +130
Misses 67 67
+ Partials 41 38 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, most of them are regarding context naming, and some missing coverage.
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix bug when is updating two entries in order