Skip to content

Conversation

scastillo-jp
Copy link
Collaborator

Screen Shot 2020-12-16 at 8 23 50 AM

@scastillo-jp scastillo-jp force-pushed the TT-39-allow-switching-among-years branch from 88587ed to cc6d25f Compare December 16, 2020 13:46
@juanultimate
Copy link
Contributor

juanultimate commented Dec 17, 2020

I am not a UI/UX expert, but IMO the year/month picker is spanning a lot of space in the screen. It would be great if you can fit all the months in a single row, and reduce/remove the padding of the card-body element,

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #588 (881c520) into master (13de42e) will increase coverage by 0.80%.
The diff coverage is 98.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage   93.09%   93.89%   +0.80%     
==========================================
  Files          85       95      +10     
  Lines        1564     1721     +157     
  Branches      107      113       +6     
==========================================
+ Hits         1456     1616     +160     
  Misses         67       67              
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 88.37% <ø> (ø)
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.28% <92.85%> (+1.47%) ⬆️
...ponents/details-fields/details-fields.component.ts 90.90% <96.66%> (+3.72%) ⬆️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2a4d5f...881c520. Read the comment docs.

@scastillo-jp scastillo-jp force-pushed the TT-39-allow-switching-among-years branch 3 times, most recently from f7067b0 to d853c48 Compare December 22, 2020 16:18
@scastillo-jp scastillo-jp force-pushed the TT-39-allow-switching-among-years branch from c6efd3f to b649ca9 Compare December 23, 2020 05:42
@scastillo-jp scastillo-jp force-pushed the TT-39-allow-switching-among-years branch 4 times, most recently from 97496cd to 1ce2bd7 Compare December 28, 2020 21:41
@gqroot gqroot force-pushed the TT-39-allow-switching-among-years branch from 1ce2bd7 to 3c09e3a Compare December 28, 2020 23:17
@gqroot gqroot force-pushed the TT-39-allow-switching-among-years branch from 3c09e3a to fc2587a Compare December 29, 2020 17:18
@gqroot gqroot force-pushed the TT-39-allow-switching-among-years branch from 40cf8f7 to 881c520 Compare December 29, 2020 17:47
Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josepato87 josepato87 dismissed juanultimate’s stale review December 29, 2020 17:56

It's resolved and he is on vacation

@josepato87 josepato87 self-requested a review December 29, 2020 17:57
Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josepato87 josepato87 merged commit d23967c into master Dec 29, 2020
@josepato87 josepato87 deleted the TT-39-allow-switching-among-years branch December 29, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants