-
Notifications
You must be signed in to change notification settings - Fork 1
TT-39 fix: comments #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-39 fix: comments #588
Conversation
scastillo-jp
commented
Dec 16, 2020
88587ed
to
cc6d25f
Compare
src/app/modules/shared/components/month-picker/month-picker.component.ts
Show resolved
Hide resolved
I am not a UI/UX expert, but IMO the year/month picker is spanning a lot of space in the screen. It would be great if you can fit all the months in a single row, and reduce/remove the |
src/app/modules/shared/components/month-picker/month-picker.component.html
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
==========================================
+ Coverage 93.09% 93.89% +0.80%
==========================================
Files 85 95 +10
Lines 1564 1721 +157
Branches 107 113 +6
==========================================
+ Hits 1456 1616 +160
Misses 67 67
+ Partials 41 38 -3
Continue to review full report at Codecov.
|
f7067b0
to
d853c48
Compare
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
c6efd3f
to
b649ca9
Compare
src/app/modules/shared/components/month-picker/month-picker.component.html
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/month-picker/month-picker.component.scss
Outdated
Show resolved
Hide resolved
97496cd
to
1ce2bd7
Compare
1ce2bd7
to
3c09e3a
Compare
3c09e3a
to
fc2587a
Compare
src/app/modules/shared/components/month-picker/month-picker.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/month-picker/month-picker.component.ts
Outdated
Show resolved
Hide resolved
40cf8f7
to
881c520
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's resolved and he is on vacation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM