Skip to content

Conversation

@gqroot
Copy link

@gqroot gqroot commented Dec 10, 2020

This PR is the 1st part of the task, the 2nd part is in the backend

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #584 (2540f9c) into master (13de42e) will increase coverage by 0.32%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   93.09%   93.42%   +0.32%     
==========================================
  Files          85       92       +7     
  Lines        1564     1642      +78     
  Branches      107      107              
==========================================
+ Hits         1456     1534      +78     
- Misses         67       70       +3     
+ Partials       41       38       -3     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...les/shared/components/sidebar/sidebar.component.ts 88.88% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 83.33% <87.50%> (+0.52%) ⬆️
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 92.20% <100.00%> (+5.02%) ⬆️
.../components/entry-fields/entry-fields.component.ts 93.22% <100.00%> (-6.78%) ⬇️
...project-list-hover/project-list-hover.component.ts 88.63% <100.00%> (+0.26%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4844725...2540f9c. Read the comment docs.

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some refactoring suggestions

@gqroot gqroot force-pushed the TT-69_OverlapHours branch from 18087da to ffb67e5 Compare December 10, 2020 23:12
@gqroot gqroot requested a review from josepato87 December 10, 2020 23:17
@gqroot gqroot merged commit 5cbe799 into master Dec 11, 2020
@gqroot gqroot deleted the TT-69_OverlapHours branch December 11, 2020 16:03
@gqroot gqroot requested review from Angeluz-07 and juanultimate and removed request for Angeluz-07 and juanultimate December 14, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants