Tt 65 change design time in #583
Conversation
PaulRC-ioet
commented
Dec 10, 2020
PaulRC-ioet
commented
- change the design of "time in" field
- add waitForAsync in the tests
- change in the .json file the commit message
PaulRC-ioet
requested review from
Angeluz-07,
enriquezrene,
gqroot,
josepato87 and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 93.09% 93.56% +0.46%
==========================================
Files 85 92 +7
Lines 1564 1647 +83
Branches 107 107
==========================================
+ Hits 1456 1541 +85
- Misses 67 70 +3
+ Partials 41 36 -5
Continue to review full report at Codecov.
|
| @@ -1,4 +1,4 @@ | |||
| <form [formGroup]="entryForm" (ngSubmit)="onSubmit()"> | |||
| <form [formGroup]="entryForm"> | |||
There was a problem hiding this comment.
I am concerned about this change. As I remember, the line you are removing, is in charge to update automatically the time entry, each time the user updates any other field, different from time in. If you remove this line, you remove that behavior, and user will have to explicitly clock out to save data. Make sure, that such behavior remains or is handled in another way.
There was a problem hiding this comment.
I also thought the same when I removed that line, but then I realized that each field has (blur) that calls the onSubmit method. It is for this reason that in my previous ticket, it did not follow the correct order, because it ran onSubmit twice.
I already tried it updating all the fields and these are perfectly updated because when clicking it runs the onSubmit method
There was a problem hiding this comment.
If we are sure that what @Angeluz-07 is not happening, go ahead. I insist that putting FF (Feature Toggle) would help to solve the problem.
There was a problem hiding this comment.
@PaulRC-ioet it's ok buddy if you checked it. Just wanted to highlight that.
There was a problem hiding this comment.
Sure, I tried it again and it didn't give me an error @josepato87 @Angeluz-07
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Outdated
Show resolved
Hide resolved
|
|
||
| <label class="col-12 col-sm-2">Time in:</label> | ||
| <div class="col-12 col-sm-4"> | ||
| <input |
There was a problem hiding this comment.
Maybe we could put this under a Feature Toggle, so if something goes wrong we could change to the precious behavior without reverting changes.
There was a problem hiding this comment.
Sure, for the next tickets would be, now I have the idea to implement those feature toggles.
|
|
||
| <label class="col-12 col-sm-2">Time out:</label> | ||
| <div class="col-12 col-sm-4"> | ||
| <input |
There was a problem hiding this comment.
the same as previous comment about FF (Feature Flags)
| @@ -1,4 +1,4 @@ | |||
| <form [formGroup]="entryForm" (ngSubmit)="onSubmit()"> | |||
| <form [formGroup]="entryForm"> | |||
There was a problem hiding this comment.
If we are sure that what @Angeluz-07 is not happening, go ahead. I insist that putting FF (Feature Toggle) would help to solve the problem.
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
