Skip to content

TT-15 keep the user logged in #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 9, 2020
Merged

TT-15 keep the user logged in #582

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e8d180
TT-15 fix: Keep the user logged in the browser
Dec 4, 2020
79ef1bf
TT-15 fix: unit test
Dec 4, 2020
8fd812b
TT-15 fix: setCookies for sing up or login test
Dec 9, 2020
8d7d975
TT-15 fix: add test for login when cookie does not exist
Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TT-15 fix: setCookies for sing up or login test
  • Loading branch information
Guido Quezada committed Dec 9, 2020
commit 8fd812ba70f61e1e7d00485b007767af3d48284f
6 changes: 5 additions & 1 deletion src/app/modules/login/login.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ describe('LoginComponent', () => {
},
signIn() {
return of();
},
setCookies() {
}
};

Expand Down Expand Up @@ -51,9 +53,11 @@ describe('LoginComponent', () => {

it('should sign up or login with google if is not logged-in into the app', inject([Router], (router: Router) => {
spyOn(azureAdB2CService, 'isLogin').and.returnValue(false);
spyOn(azureAdB2CService, 'signIn').and.returnValue(of());
spyOn(azureAdB2CService, 'setCookies').and.returnValue();
spyOn(azureAdB2CService, 'signIn').and.returnValue(of(() => {}));
component.login();
expect(azureAdB2CService.signIn).toHaveBeenCalled();
expect(azureAdB2CService.setCookies).toHaveBeenCalled();
}));

it('should not sign-up or login with google if is already logged-in into the app', inject([Router], (router: Router) => {
Expand Down