feat: #566 Datepicker for departure date in entry form #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
==========================================
+ Coverage 93.09% 93.36% +0.27%
==========================================
Files 85 92 +7
Lines 1564 1613 +49
Branches 107 105 -2
==========================================
+ Hits 1456 1506 +50
- Misses 67 69 +2
+ Partials 41 38 -3
Continue to review full report at Codecov.
|
gqroot
force-pushed
the
566_ManualTimeEntries
branch
from
eab4210 to
22a3250
Compare
gqroot
force-pushed
the
566_ManualTimeEntries
branch
from
22a3250 to
4aa0c14
Compare
enriquezrene
suggested changes
Nov 27, 2020
| @@ -311,7 +315,7 @@ describe('DetailsFieldsComponent', () => { | |||
| spyOn(toastrServiceStub, 'error'); | |||
|
|
|||
| const futureDate = moment().add(1, 'days').format('YYYY-MM-DD'); | |||
| component.entryForm.setValue({ ...formValues, entry_date: futureDate }); | |||
| component.entryForm.setValue({ ...formValues, entry_date: futureDate, departure_date: futureDate }); | |||
| component.onSubmit(); | |||
There was a problem hiding this comment.
You need to add a couple of tests here:
- start_date in the future / end date OK
- start_date OK / end date in the future
src/app/modules/shared/components/details-fields/details-fields.component.ts
Outdated
Show resolved
Hide resolved
|
It seems much more user friendly to show in the same row the start date/time, and in the next row the end date/time. This may lead to confusion.
|
src/app/modules/shared/components/details-fields/details-fields.component.spec.ts
Outdated
Show resolved
Hide resolved
gqroot
changed the title
enriquezrene
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.