Skip to content

Conversation

@PaulRC-ioet
Copy link
Contributor

Test creation for the missing effects and selectors files to improve the coverage.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #579 (13de42e) into master (fd525f8) will increase coverage by 2.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   90.54%   93.09%   +2.54%     
==========================================
  Files          80       85       +5     
  Lines        1428     1564     +136     
  Branches      107      107              
==========================================
+ Hits         1293     1456     +163     
+ Misses         94       67      -27     
  Partials       41       41              
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 92.10% <100.00%> (+0.67%) ⬆️
...eate-project-type/create-project-type.component.ts 95.65% <100.00%> (ø)
...ponents/create-project/create-project.component.ts 97.14% <100.00%> (+0.08%) ⬆️
...modules/shared/components/clock/clock.component.ts 91.66% <0.00%> (-8.34%) ⬇️
...-management/store/activity-management.selectors.ts 87.50% <0.00%> (ø)
...onents/projects-type/store/project-type.effects.ts 100.00% <0.00%> (ø)
...er-management/store/customer-management.effects.ts 100.00% <0.00%> (ø)
...nents/projects/components/store/project.effects.ts 100.00% <0.00%> (ø)
...es-management/store/activity-management.effects.ts 100.00% <0.00%> (ø)
src/app/modules/shared/store/technology.effects.ts 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8bfd1...13de42e. Read the comment docs.

});

it('should select getProjects', () => {
const project = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects? plural, right?

@enriquezrene enriquezrene merged commit a474cf1 into master Nov 24, 2020
@enriquezrene enriquezrene deleted the 0000_addTestingFiles branch November 24, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants