571 ui list trending technologies#577
Merged
Merged
Conversation
Collaborator
scastillo-jp
commented
Nov 19, 2020

Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 93.09% 93.42% +0.33%
==========================================
Files 85 95 +10
Lines 1564 1674 +110
Branches 107 109 +2
==========================================
+ Hits 1456 1564 +108
- Misses 67 73 +6
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
enriquezrene
suggested changes
Nov 20, 2020
Contributor
enriquezrene
left a comment
There was a problem hiding this comment.
Does it make sense to have some empty files like the .spec (which also has a typo ...technology-report.component.spect.ts
On the other hand, this seems the perfect candidate for feature toggles, it is completely useless to display a page with dummy data. Please use feature toggles for this.
94c9527 to
6ef2578
Compare
ca8c14a to
93bf82c
Compare
67e8d0b to
b96563a
Compare
Contributor
|
For reviewers. To review the use of FT in this new feature, check the following files: |
77c81ae to
2965e16
Compare
josepato87
reviewed
Dec 12, 2020
dc14411 to
56283c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.