-
Notifications
You must be signed in to change notification settings - Fork 1
571 ui list trending technologies #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scastillo-jp
commented
Nov 19, 2020

Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 93.09% 93.42% +0.33%
==========================================
Files 85 95 +10
Lines 1564 1674 +110
Branches 107 109 +2
==========================================
+ Hits 1456 1564 +108
- Misses 67 73 +6
+ Partials 41 37 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have some empty files like the .spec (which also has a typo ...technology-report.component.spect.ts
On the other hand, this seems the perfect candidate for feature toggles, it is completely useless to display a page with dummy data. Please use feature toggles for this.
src/app/modules/shared/time-range-form/time-range-form.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/time-range-form/time-range.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/time-range-form/time-range.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/time-range-form/time-range.component.spec.ts
Outdated
Show resolved
Hide resolved
...hnology-report/components/technology-report-table/technology-report-table.component.spect.ts
Outdated
Show resolved
Hide resolved
...es/technology-report/components/technology-report-table/technology-report-table.component.ts
Outdated
Show resolved
Hide resolved
...es/technology-report/components/technology-report-table/technology-report-table.component.ts
Outdated
Show resolved
Hide resolved
...es/technology-report/components/technology-report-table/technology-report-table.component.ts
Outdated
Show resolved
Hide resolved
94c9527 to
6ef2578
Compare
ca8c14a to
93bf82c
Compare
67e8d0b to
b96563a
Compare
|
For reviewers. To review the use of FT in this new feature, check the following files: |
77c81ae to
2965e16
Compare
dc14411 to
56283c6
Compare