Skip to content

Conversation

@scastillo-jp
Copy link
Collaborator

image

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #577 (a9150e6) into master (13de42e) will increase coverage by 0.33%.
The diff coverage is 98.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   93.09%   93.42%   +0.33%     
==========================================
  Files          85       95      +10     
  Lines        1564     1674     +110     
  Branches      107      109       +2     
==========================================
+ Hits         1456     1564     +108     
- Misses         67       73       +6     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 83.33% <85.71%> (+0.52%) ⬆️
src/app/modules/users/store/user.reducers.ts 87.50% <87.50%> (ø)
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...nologies-report-guard/technologies-report.guard.ts 100.00% <100.00%> (ø)
src/app/modules/login/login.component.ts 100.00% <100.00%> (+16.66%) ⬆️
...app/modules/login/services/azure.ad.b2c.service.ts 86.95% <100.00%> (+4.60%) ⬆️
...ponents/details-fields/details-fields.component.ts 89.61% <100.00%> (+2.43%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 92.00% <100.00%> (+3.11%) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0601f5b...a9150e6. Read the comment docs.

Copy link
Contributor

@enriquezrene enriquezrene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have some empty files like the .spec (which also has a typo ...technology-report.component.spect.ts

On the other hand, this seems the perfect candidate for feature toggles, it is completely useless to display a page with dummy data. Please use feature toggles for this.

@scastillo-jp scastillo-jp force-pushed the 571_UIListTrendingTechnologies branch 2 times, most recently from 94c9527 to 6ef2578 Compare November 20, 2020 20:49
@gqroot gqroot force-pushed the 571_UIListTrendingTechnologies branch 4 times, most recently from ca8c14a to 93bf82c Compare November 24, 2020 18:24
@Angeluz-07 Angeluz-07 force-pushed the 571_UIListTrendingTechnologies branch from 67e8d0b to b96563a Compare December 4, 2020 16:09
@Angeluz-07
Copy link
Contributor

Angeluz-07 commented Dec 9, 2020

For reviewers. To review the use of FT in this new feature, check the following files:

src/app/app-routing.module.ts 
src/app/guards/technologies-report-guard/technologies-report.guard.spec.ts
src/app/guards/technologies-report-guard/technologies-report.guard.ts 
src/app/modules/shared/components/sidebar/sidebar.component.spec.ts 
src/app/modules/shared/components/sidebar/sidebar.component.ts

@Angeluz-07 Angeluz-07 force-pushed the 571_UIListTrendingTechnologies branch from 77c81ae to 2965e16 Compare December 11, 2020 21:27
@Angeluz-07 Angeluz-07 force-pushed the 571_UIListTrendingTechnologies branch from dc14411 to 56283c6 Compare December 15, 2020 16:11
@Angeluz-07 Angeluz-07 merged commit 0cb1516 into master Dec 15, 2020
@Angeluz-07 Angeluz-07 deleted the 571_UIListTrendingTechnologies branch December 15, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants