Skip to content

Conversation

@PaulRC-ioet
Copy link
Contributor

A feature that inserts a new option to the administrator role to see the users.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #575 (7b637c9) into master (13de42e) will increase coverage by 0.09%.
The diff coverage is 94.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   93.09%   93.18%   +0.09%     
==========================================
  Files          85       92       +7     
  Lines        1564     1614      +50     
  Branches      107      109       +2     
==========================================
+ Hits         1456     1504      +48     
- Misses         67       68       +1     
- Partials       41       42       +1     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...les/shared/components/sidebar/sidebar.component.ts 88.88% <ø> (ø)
src/app/modules/users/store/user.reducers.ts 62.50% <62.50%> (ø)
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/pages/users.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/services/users.service.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.selectors.ts 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a474cf1...7b637c9. Read the comment docs.

Copy link
Contributor

@Angeluz-07 Angeluz-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Only some comments.

@enriquezrene
Copy link
Contributor

Also the table is hard to understand,

what the last column means?
is there any chance to make the table wider?
Headers should be:

  • Email
  • Name
  • Roles ---> I think a user might have more than one, right?
  • idk, what it does?

image

@enriquezrene
Copy link
Contributor

This also looks kinda ugly

image

@PaulRC-ioet
Copy link
Contributor Author

Captura de pantalla de 2020-11-20 16-04-11

This is the new model of the main view of Users

@PaulRC-ioet
Copy link
Contributor Author

Captura de pantalla de 2020-11-23 14-32-56
this would be the final design

@PaulRC-ioet PaulRC-ioet force-pushed the 569_createOptionUsers branch from 90fd4f4 to 7b637c9 Compare November 24, 2020 14:46
@scastillo-jp scastillo-jp merged commit 032ebfe into master Nov 24, 2020
@scastillo-jp scastillo-jp deleted the 569_createOptionUsers branch November 24, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants