feat: #562 Show read only GUID field #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 80 80
Lines 1441 1441
Branches 107 107
=======================================
Hits 1306 1306
- Misses 94 95 +1
+ Partials 41 40 -1
Continue to review full report at Codecov.
|
Angeluz-07
approved these changes
Nov 5, 2020
enriquezrene
suggested changes
Nov 5, 2020
| @@ -1,6 +1,17 @@ | |||
| <div class="container"> | |||
| <form style="width: 600px;" [formGroup]="customerForm" (ngSubmit)="onSubmit(customerForm.value)"> | |||
| <div class="form-group"> | |||
| <div class="form-group"> | |||
There was a problem hiding this comment.
This is not going to solve the problem, what we need to do instead is to show the uuid in the table. Please add this column in the customer list, project list, project type and activities list as well.
There was a problem hiding this comment.
Got it, Working on that!
PaulRC-ioet
force-pushed
the
562_readOnlyFieldIDCostomer
branch
from
588e51c to
1cdc1ed
Compare
|
All the changes are done @enriquezrene , delete de input with the ids, and add those ids into the tables. |
enriquezrene
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show read-only GUID field in customers and project sections.
Close #562