#3-Time clock find project #54

daros10 · 2020-03-28T00:26:09Z

This PR contains the functionality to search for projects in Time Clock and Prjocte views.

… Time-Clock-Timer-Component

… TimeClock-find-project-#3

…ime-tracker-ui into TimeClock-find-project-#3

macrisguncay

We should only see in "app-project-list-hover" an active projects list but I can see all projects.

macrisguncay · 2020-03-30T05:21:21Z

src/app/components/shared/search-project/search-project.component.html

@@ -0,0 +1,3 @@
+<div class="form-group">
+    <input (keyup)="changeFilterValue()" type="text" class="form-control" placeholder="&#xF002; Search project" name="filterProject" [(ngModel)]="filterProject" style="font-family:'Segoe UI', Tahoma, Geneva, Verdana, sans-serif, FontAwesome">


Please, fix the indentation, remember that we are using an indentation based in 2 spaces.

macrisguncay · 2020-03-30T05:21:55Z

src/app/components/shared/project-list/project-list.component.html

+                <div class="card" *ngFor="let project of projects | filterProject:filterProjects; let rowIndex = index">
+                    <div class="card-header">
+                        <h2 class="mb-0">
+                            <a type="button" data-toggle="collapse" [attr.data-target]="'#row'+rowIndex" [attr.aria-controls]="'row'+rowIndex">


Please, fix the indentation, remember that we are using an indentation based in 2 spaces.

macrisguncay · 2020-03-30T05:22:35Z

src/app/components/shared/project-list-hover/project-list-hover.component.html

-      *ngIf="showButton === i && selectedId !== item.id"
-      class="badge badge-light"
-      >Clock In</span
+    <li class="list-group-item list-group-item-action d-flex justify-content-between align-items-center" *ngFor="let item of projects | filterProject:filterProjects;  let i = index" (mouseenter)="showButton = i" (mouseleave)="showButton = -1" (click)="clockIn(item.id)"


Please, fix the indentation, remember that we are using an indentation based in 2 spaces.

macrisguncay · 2020-03-30T05:25:13Z

src/app/components/options-sidebar/time-clock/time-clock.component.ts

@@ -99,8 +99,9 @@ export class TimeClockComponent  implements OnInit {
   timer() {
    this.secondsCounterRealTime += 1;
    if ( this.secondsCounterRealTime === 59 ) {
-      this.minuteCounterRealTime += 1;
-      this.secondsCounterRealTime = 0;
+      console.log('entroooo');


Remove console log please.

macrisguncay · 2020-03-30T05:26:35Z

src/app/components/options-sidebar/time-clock/time-clock.component.html

-        <div class="col-10 text-right">
-          <i class="far fa-question-circle"></i>
+<div class="text-center mt-5">
+    <div class="card">


Please, fix the indentation, remember that we are using an indentation based in 2 spaces.

macrisguncay · 2020-03-30T05:27:26Z

src/app/components/options-sidebar/project-management/project-management.component.html

-  </app-project-list>
-</div>
+    <app-create-project class="item" [projectToEdit]="project" (savedProject)="updateProject($event)" (cancelForm)="cancelForm()">
+    </app-create-project>


please, fix the indentation, remember that we are using an indentation based in 2 spaces.

enriquezrene · 2020-03-30T16:25:16Z

src/app/components/options-sidebar/time-clock/time-clock.component.spec.ts

@@ -197,6 +198,13 @@ describe('TimeClockComponent', () => {
      expect(component.secondsCounterRealTime).not.toEqual(0);
    });

+  it('inside timer first if' , () => {


I don't understand what this test is doing?
Could you please explain what are you testing here?

enriquezrene · 2020-03-30T16:25:41Z

src/app/components/options-sidebar/time-clock/time-clock.component.ts

+
+  employeClockIn(): boolean {
+    this.isClockInEnable = true;
+    this.isClockIn = !this.isClockIn;


this.isClockIn = true; ???

enriquezrene · 2020-03-30T16:26:35Z

src/app/components/options-sidebar/time-clock/time-clock.component.ts

+    this.isHidenForm = false;
+    this.startTimer();
+    this.setArrivalAndDepartureTimes();
+    return this.isClockIn;


why are you returning a value here?
I think the intention of this function is to notify the user has clicked on clock-in, right?

enriquezrene · 2020-03-30T16:27:24Z

src/app/components/options-sidebar/time-clock/time-clock.component.ts

+  }
+
+  employeClockOut() {
+    if (this.isEnterTechnology === false) {


Since users can enter more than one technologies, you should rename this var to:
this.areTechnologiesEntered

enriquezrene · 2020-03-30T16:28:04Z

src/app/components/options-sidebar/time-clock/time-clock.component.ts

+    }
+  }
+
+  enterTechnology(data: string) {


what is the intention of this function?

enriquezrene · 2020-03-30T16:28:58Z

src/app/components/shared/clock/clock.component.spec.ts

@@ -45,4 +45,18 @@ describe('ClockComponent', () => {
    expect(component.showClock).toHaveBeenCalled();
  });

+  it('should be verify the init state of vars' , () => {


what are you testing here?

enriquezrene · 2020-03-30T16:29:10Z

src/app/components/shared/clock/clock.component.spec.ts

+    expect(component.displayTime).toBeFalsy();
+  });
+
+  it('should enter if and assign the value to vars' , () => {


what are you testing here?

enriquezrene · 2020-03-30T16:30:40Z

src/app/components/shared/pipes/filter-project/filter-project.pipe.ts

+    const restultProjects = [];
+    // tslint:disable-next-line: prefer-for-of
+    for ( let i = 0; i < value.length; i++ ) {
+      if ( value[i].name.toLowerCase().indexOf(arg.toLowerCase()) > -1 ) {


This if statement should be tested since this is the logic we want to make sure it's working.

enriquezrene · 2020-03-30T16:31:39Z

src/app/components/shared/search-project/search-project.component.spec.ts

+    expect(component).toBeTruthy();
+  });
+
+  it('called method' , () => {


what are you testing here?

enriquezrene · 2020-03-30T16:32:10Z

src/app/components/shared/sidebar/sidebar.component.html

-          <a [routerLink]="['/project-management']" routerLinkActive="dark" class="list-group-item list-group-item-action bg-light"><i class="far fa-folder-open"></i>   Projects</a>
-          <a [routerLink]="['/activities-management']" routerLinkActive="dark" class="list-group-item list-group-item-action bg-light"><i class="far fa-file-alt"></i>   Activities</a>
-        </div>
+  <!-- Sidebar -->


Please rebase your branch against master. This code has been already updated.

daros10 added 10 commits March 25, 2020 18:34

added test

22b7119

Merge branch 'master' of https://github.com/ioet/time-tracker-ui into…

e15d20c

… Time-Clock-Timer-Component

Update time-clock.component.html

c501044

#3 serach project in view project

56247f6

#3 added search in time clock view

f4b586c

Merge branch 'master' of https://github.com/ioet/time-tracker-ui into…

de4fbd6

… TimeClock-find-project-#3

#3 added comma in modules

75b33b3

added unit test

ae78b3d

#3 find project

e2ac439

Merge branch 'TimeClock-find-project-#3' of https://github.com/ioet/t…

01696cf

…ime-tracker-ui into TimeClock-find-project-#3

daros10 requested review from enriquezrene and macrisguncay March 28, 2020 00:26

macrisguncay reviewed Mar 30, 2020

View reviewed changes

format code indentation based in 2 spaces.

7c8ca50

enriquezrene suggested changes Mar 30, 2020

View reviewed changes

daros10 closed this Mar 31, 2020

daros10 deleted the TimeClock-find-project-#3 branch March 31, 2020 01:08

		@@ -0,0 +1,3 @@
		<div class="form-group">
		<input (keyup)="changeFilterValue()" type="text" class="form-control" placeholder=" Search project" name="filterProject" [(ngModel)]="filterProject" style="font-family:'Segoe UI', Tahoma, Geneva, Verdana, sans-serif, FontAwesome">

#3-Time clock find project #54

#3-Time clock find project #54

Uh oh!

Conversation

daros10 commented Mar 28, 2020

Uh oh!

macrisguncay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!