-
Notifications
You must be signed in to change notification settings - Fork 1
fix: make responsive forms of activities section #537 #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 74 74
Lines 1388 1388
Branches 101 101
=======================================
Hits 1258 1258
Misses 91 91
Partials 39 39 Continue to review full report at Codecov.
|
| @@ -1,0 +1,9 @@ | |||
| .activity-container{ | |||
| width: 100%; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bootstrap has a w-100 class which does this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes bootstrap has those classes, but I created this class to use the media-query. On desktop screen we need 70% of width, but in phone we need 100%. Kind of style conditionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if can do it, only with bootstrap classes, without using empty divs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You gave me the idea. I could do it with bootstrap classes only. Thanks
|
|
||
| @media (min-width: 992px) { | ||
| .activity-container{ | ||
| width: 70%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrap has a w-75 class. I do not know if it can serve to the purpose u want.
40b1fa7 to
4ec56ed
Compare
close #537