Skip to content

Conversation

Angeluz-07
Copy link
Contributor

close #537

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #538 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files          74       74           
  Lines        1388     1388           
  Branches      101      101           
=======================================
  Hits         1258     1258           
  Misses         91       91           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5842c...4ec56ed. Read the comment docs.

@@ -0,0 +1,9 @@
.activity-container{
width: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap has a w-100 class which does this

Copy link
Contributor Author

@Angeluz-07 Angeluz-07 Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes bootstrap has those classes, but I created this class to use the media-query. On desktop screen we need 70% of width, but in phone we need 100%. Kind of style conditionally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if can do it, only with bootstrap classes, without using empty divs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You gave me the idea. I could do it with bootstrap classes only. Thanks


@media (min-width: 992px) {
.activity-container{
width: 70%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap has a w-75 class. I do not know if it can serve to the purpose u want.

@Angeluz-07 Angeluz-07 force-pushed the 537_fix_forms_activities branch from 40b1fa7 to 4ec56ed Compare October 14, 2020 23:01
@Angeluz-07 Angeluz-07 merged commit 913fad6 into master Oct 14, 2020
@Angeluz-07 Angeluz-07 deleted the 537_fix_forms_activities branch October 14, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix forms of activities section
2 participants