Adding support for feature flags on UI #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanultimate
force-pushed
the
feature-toggles
branch
5 times, most recently
from
5e667c1 to
fa18b4e
Compare
juanultimate
force-pushed
the
feature-toggles
branch
from
fa18b4e to
7d4b8e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
==========================================
- Coverage 90.90% 90.88% -0.03%
==========================================
Files 73 74 +1
Lines 1364 1371 +7
Branches 97 97
==========================================
+ Hits 1240 1246 +6
Misses 90 90
- Partials 34 35 +1
Continue to review full report at Codecov.
|
juanultimate
commented
Sep 22, 2020
|
|
||
| const APP_CONFIGURATION_CLIENT = new InjectionToken<AppConfigurationClient>('Azure configuration client', { | ||
| providedIn: 'root', | ||
| factory: () => new AppConfigurationClient(AZURE_APP_CONFIGURATION_CONNECTION_STRING) |
There was a problem hiding this comment.
Not sure if I should change the way I test this component so that the coverage report does not complain about not reaching this line on unit tests.
enriquezrene
approved these changes
Oct 6, 2020
|
|
||
| const APP_CONFIGURATION_CLIENT = new InjectionToken<AppConfigurationClient>('Azure configuration client', { | ||
| providedIn: 'root', | ||
| factory: () => new AppConfigurationClient(AZURE_APP_CONFIGURATION_CONNECTION_STRING) |
|
closes #522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for feature flags on UI