Skip to content

Conversation

Angeluz-07
Copy link
Contributor

fixes #481

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #482 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   90.46%   90.69%   +0.22%     
==========================================
  Files          73       73              
  Lines        1343     1343              
  Branches       95       94       -1     
==========================================
+ Hits         1215     1218       +3     
+ Misses         92       90       -2     
+ Partials       36       35       -1     
Impacted Files Coverage Δ
...dules/time-entries/pages/time-entries.component.ts 87.03% <100.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce748d7...c934b91. Read the comment docs.

Copy link
Contributor

@juanultimate juanultimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No unit tests?
I am reading the ticket description and it says "A solution would be to refresh the active-time-entry on edit.", so I would create a unit test that validates so. Something like this:

it('when editing a time entry, then the active time entry is loaded'){
 //setup scenario (Arrange)
 // trigger a time-entry edition (Act)
 // validates the time entry is loaded/refreshed (Assert)
}

Copy link
Contributor

@juanultimate juanultimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One commit is enough. Please remember unit tests and production code are a single piece.

@Angeluz-07 Angeluz-07 merged commit 34450e9 into master Aug 4, 2020
@Angeluz-07 Angeluz-07 deleted the 481-clock-overlap branch August 4, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to create time-entry when modify and save a running time-entry
2 participants