Skip to content

Conversation

juanultimate
Copy link
Contributor

  • It adds a loading bar when the tables' information is being queried from the backend.
  • Extracting time-entries array and IsLoading flag to a DataSource type.
  • Fixing some typos
  • Removing dead code
    Jul-27-2020 21-21-39

@juanultimate juanultimate force-pushed the 452-spinner-on-loading-data branch 2 times, most recently from ea32332 to 6933787 Compare July 28, 2020 02:41
Extracting time-entries table source as datasource objects
Removing dead code
Using types on unit tests
Fixing unit tests
@juanultimate juanultimate force-pushed the 452-spinner-on-loading-data branch from 6933787 to a2ff91e Compare July 28, 2020 02:47
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #477 into master will decrease coverage by 0.89%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   89.50%   88.61%   -0.90%     
==========================================
  Files          72       73       +1     
  Lines        1324     1317       -7     
  Branches       93       92       -1     
==========================================
- Hits         1185     1167      -18     
- Misses        109      114       +5     
- Partials       30       36       +6     
Impacted Files Coverage Δ
...ponents/details-fields/details-fields.component.ts 82.08% <ø> (-4.48%) ⬇️
.../components/technologies/technologies.component.ts 84.84% <ø> (ø)
...p/modules/time-clock/pages/time-clock.component.ts 91.66% <ø> (ø)
src/app/modules/time-clock/store/entry.actions.ts 100.00% <ø> (ø)
...rc/app/modules/time-clock/store/entry.selectors.ts 25.00% <14.28%> (-67.31%) ⬇️
...time-entries-table/time-entries-table.component.ts 57.89% <33.33%> (-4.02%) ⬇️
...nts/projects/components/store/project.selectors.ts 60.00% <50.00%> (-25.72%) ⬇️
...-management/store/customer-management.selectors.ts 73.68% <50.00%> (-2.79%) ⬇️
...-management/store/activity-management.selectors.ts 87.50% <75.00%> (-1.39%) ⬇️
src/app/modules/time-clock/store/entry.reducer.ts 97.61% <75.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e09b3f4...a2ff91e. Read the comment docs.

@juanultimate juanultimate changed the title 452 loading bar on loading data 452 loading bar when loading data Jul 28, 2020
@enriquezrene enriquezrene merged commit 3e7f631 into master Jul 28, 2020
@enriquezrene enriquezrene deleted the 452-spinner-on-loading-data branch July 28, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants