Skip to content

fix: #397 display time-in and time-out columns #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2020
Merged

fix: #397 display time-in and time-out columns #475

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea7a90
fix: #397 display time-in and time-out columns
enriquezrene Jul 22, 2020
5f8336f
fix: #397 remove dead code
enriquezrene Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: #397 remove dead code
  • Loading branch information
@enriquezrene
enriquezrene committed Jul 22, 2020
commit 5f8336fce23f378819a716c636d37b882dd7b2a8
2 changes: 0 additions & 2 deletions src/app/modules/time-clock/services/entry.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@ import * as moment from 'moment';
describe('EntryService', () => {
let service: EntryService;
let httpMock: HttpTestingController;
let datePipe: DatePipe;

beforeEach(() => {
TestBed.configureTestingModule({imports: [HttpClientTestingModule], providers: [DatePipe]});
service = TestBed.inject(EntryService);
httpMock = TestBed.inject(HttpTestingController);
datePipe = TestBed.inject(DatePipe);
service.baseUrl = 'time-entries';
});

Expand Down
4 changes: 3 additions & 1 deletion src/app/modules/time-clock/store/entry.selectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ export const getCreateError = createSelector(getEntryState, (state: EntryState)
});

export const getUpdateError = createSelector(getEntryState, (state: EntryState) => {
return state.updateError;
if (state) {
return state.updateError;
}
});
export const getStatusMessage = createSelector(getEntryState, (state: EntryState) => state.message);

Expand Down