fix: validate future date #459 #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
- Coverage 89.78% 89.74% -0.05%
==========================================
Files 72 72
Lines 1312 1316 +4
Branches 88 89 +1
==========================================
+ Hits 1178 1181 +3
- Misses 104 105 +1
Partials 30 30
Continue to review full report at Codecov.
|
juanultimate
approved these changes
Jul 7, 2020
| delete entry.end_date; | ||
| } | ||
|
|
||
| const invalidEntryDate = new Date(entryDate) > new Date(); |
There was a problem hiding this comment.
I would name this variables as isEntryDateInTheFuture
Angeluz-07
force-pushed
the
459-working-this-not-future-date
branch
from
c2c5256 to
93ca91e
Compare
enriquezrene
approved these changes
Jul 8, 2020
enriquezrene
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.