Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/app/modules/time-clock/services/entry.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,18 @@ describe('EntryService', () => {
expect(loadEntryRequest.request.params.get('user_id')).toEqual('123');
});

it('when getting time entries for report, limit parameter should be sent', () => {
const yesterday = moment(new Date()).subtract(1, 'day');
const today = moment(new Date());
const timeRange: TimeEntriesTimeRange = { start_date: yesterday, end_date: today };
const userId = '123';

service.loadEntriesByTimeRange(timeRange, userId).subscribe();

const loadEntryRequest = httpMock.expectOne(req => req.method === 'GET' && req.url === service.baseUrl);
expect(loadEntryRequest.request.params.get('limit')).toEqual('9999');
});

it('when restarting entry, a POST is triggered', () => {
const entry = 'entryId';

Expand Down
4 changes: 3 additions & 1 deletion src/app/modules/time-clock/services/entry.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,14 @@ export class EntryService {
}

loadEntriesByTimeRange(range: TimeEntriesTimeRange, userId: string): Observable<any> {
const MAX_NUMBER_OF_ENTRIES_FOR_REPORTS = 9999;
return this.http.get(this.baseUrl,
{
params: {
start_date: this.datePipe.transform(range.start_date, EntryService.TIME_ENTRIES_DATE_TIME_FORMAT),
end_date: this.datePipe.transform(range.end_date, EntryService.TIME_ENTRIES_DATE_TIME_FORMAT),
user_id: userId
user_id: userId,
limit: `${MAX_NUMBER_OF_ENTRIES_FOR_REPORTS}`
}
}
);
Expand Down