Skip to content

Conversation

enriquezrene
Copy link
Contributor

closes #423 sets current date to avoid issues updating data of running entry
closes #414 errors trying to update entry
closes #434 enhance report file name

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #435 into master will increase coverage by 0.21%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   90.36%   90.57%   +0.21%     
==========================================
  Files          72       72              
  Lines        1297     1284      -13     
  Branches       87       82       -5     
==========================================
- Hits         1172     1163       -9     
+ Misses         96       94       -2     
+ Partials       29       27       -2     
Impacted Files Coverage Δ
...time-entries-table/time-entries-table.component.ts 76.47% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 89.74% <ø> (+6.72%) ⬆️
...ponents/details-fields/details-fields.component.ts 91.93% <71.42%> (-0.13%) ⬇️
src/app/modules/time-clock/store/entry.effects.ts 46.83% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800346e...c9384d4. Read the comment docs.

@enriquezrene enriquezrene merged commit ddbedf8 into master Jun 29, 2020
@enriquezrene enriquezrene deleted the 414-fix-time-on-stop branch June 29, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance report file name generated Random fails when updating an active entry in the Time entries page Error when trying to update time entry
1 participant