Skip to content

set seconds to zero on create time-entry #399 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2020
Merged

set seconds to zero on create time-entry #399 #416

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d5a8a5
fix: update doSave function #399
Angeluz-07 Jun 23, 2020
c0193b2
fix: add flag to check end_date is defined #399
Angeluz-07 Jun 23, 2020
82a4ff9
fix: extract method to adjust seconds #399
Angeluz-07 Jun 24, 2020
4944d40
fix: #399 fix broken unit tests
enriquezrene Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: #399 fix broken unit tests
  • Loading branch information
@enriquezrene
enriquezrene committed Jun 24, 2020
commit 4944d40df5026e3c142ed1fc3c7ece82ddc8218c
2 changes: 2 additions & 0 deletions src/app/modules/time-entries/pages/time-entries.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ describe('TimeEntriesComponent', () => {
});

it('should dispatch an action when entry is going to be saved', () => {
component.entry = { start_date: new Date(), id: '1234', technologies: []};
const newEntry = {
entry: {
project_id: 'p-id',
Expand Down Expand Up @@ -308,6 +309,7 @@ describe('TimeEntriesComponent', () => {
}));

it('when event contains should restart as true, then a restart Entry action should be triggered', () => {
component.entry = { start_date: new Date(), id: '1234', technologies: []};
const entryToSave = {
entry: {
id: '123',
Expand Down