Skip to content

Conversation

@DiegoTinitana
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #411 into master will increase coverage by 0.13%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   90.27%   90.40%   +0.13%     
==========================================
  Files          72       72              
  Lines        1234     1251      +17     
  Branches       78       80       +2     
==========================================
+ Hits         1114     1131      +17     
  Misses         92       92              
  Partials       28       28              
Impacted Files Coverage Δ
...p/modules/time-clock/pages/time-clock.component.ts 66.66% <40.00%> (-15.16%) ⬇️
.../components/entry-fields/entry-fields.component.ts 88.00% <100.00%> (+0.50%) ⬆️
...project-list-hover/project-list-hover.component.ts 85.71% <0.00%> (-0.40%) ⬇️
src/app/modules/time-clock/store/entry.actions.ts 100.00% <0.00%> (ø)
src/app/modules/time-clock/store/entry.reducer.ts 97.61% <0.00%> (+0.11%) ⬆️
src/app/modules/time-clock/store/entry.effects.ts 46.47% <0.00%> (+1.02%) ⬆️
...modules/shared/components/clock/clock.component.ts 100.00% <0.00%> (+41.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8afbfe7...4a49635. Read the comment docs.

this.areFieldsVisible = false;
}

clockOut() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can add unit tests to this new code?

@DiegoTinitana DiegoTinitana force-pushed the 395_Make_the_activity_required_when_clocking-out branch from 89740ad to a5a52ac Compare June 23, 2020 17:47
@DiegoTinitana DiegoTinitana force-pushed the 395_Make_the_activity_required_when_clocking-out branch from a5a52ac to 4a49635 Compare June 23, 2020 18:44
@enriquezrene enriquezrene merged commit 364d8a0 into master Jun 24, 2020
@enriquezrene enriquezrene deleted the 395_Make_the_activity_required_when_clocking-out branch June 24, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants