Skip to content

fix: 👽 add time_offset query param to summary endpoint #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020
Merged

fix: 👽 add time_offset query param to summary endpoint #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: 👽 add time_offset query param to summary endpoint
  • Loading branch information
@Angeluz-07
Angeluz-07 committed Jun 18, 2020
commit 2611c14f89b46de5387afbcd97d2ba19fb3cf7c5
6 changes: 3 additions & 3 deletions src/app/modules/time-clock/services/entry.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ describe('EntryService', () => {
expect(loadEntryRequest.request.method).toBe('GET');
});

it('loads summary with get /summary', () => {
it('loads summary with get /summary?time_offset=<time-offset>', () => {
service.summary().subscribe();

const loadEntryRequest = httpMock.expectOne(`${service.baseUrl}/summary`);
const time_offset = new Date().getTimezoneOffset();
const loadEntryRequest = httpMock.expectOne(`${service.baseUrl}/summary?time_offset=${time_offset}`);
expect(loadEntryRequest.request.method).toBe('GET');
});

Expand Down
3 changes: 2 additions & 1 deletion src/app/modules/time-clock/services/entry.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export class EntryService {
}

summary(): Observable<TimeEntriesSummary> {
const summaryUrl = `${this.baseUrl}/summary`;
const time_offset = new Date().getTimezoneOffset();
const summaryUrl = `${this.baseUrl}/summary?time_offset=${time_offset}`;
return this.http.get<TimeEntriesSummary>(summaryUrl);
}

Expand Down