Skip to content

Conversation

DiegoTinitana
Copy link
Contributor

No description provided.

@enriquezrene
Copy link
Contributor

@DiegoTinitana make sure the env vars are added before deploying this change.

@DiegoTinitana DiegoTinitana force-pushed the add_security_azure_AD_B2C branch 12 times, most recently from 4d5897b to d3c7bd0 Compare March 31, 2020 22:00
README.md Outdated
@@ -18,6 +18,8 @@ Run `npm install -g @angular/cli` to install Angular CLI

Run `npm install` to install the required node_modules for this project.

Create file .keys.json from keys.example.ts into environments folder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this text shouldn't in this section, you can search a better section or you can add a title to describe it.

@DiegoTinitana DiegoTinitana force-pushed the add_security_azure_AD_B2C branch 2 times, most recently from d85309f to 05897da Compare April 1, 2020 18:04
@enriquezrene enriquezrene force-pushed the add_security_azure_AD_B2C branch from a808226 to ce100ae Compare April 1, 2020 20:55

it('should check if is login', () => {
spyOn(azureAdB2CService, 'isLogin').and.returnValue(true)
const isAcitve = service.canActivate();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: isActive

@enriquezrene enriquezrene merged commit e592d21 into master Apr 1, 2020
@enriquezrene enriquezrene deleted the add_security_azure_AD_B2C branch April 1, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants