Skip to content

fix: #328 removing cleaning data from form #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enriquezrene merged 1 commit into from
Jun 3, 2020
Merged

fix: #328 removing cleaning data from form #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: #328 removing cleaning data from form
  • Loading branch information
@enriquezrene
enriquezrene committed Jun 3, 2020
commit 609d97d748744436e83197ee5eaed4a009fbf225
2 changes: 1 addition & 1 deletion src/app/modules/shared/components/details-fields/details-fields.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
</div>
<div class="modal-footer">
<button type="submit" class="btn btn-primary" [disabled]="!entryForm.valid">Save</button>
<button #closeModal type="button" class="btn btn-secondary" data-dismiss="modal" (click)="close()">
<button #closeModal type="button" class="btn btn-secondary" data-dismiss="modal" >
Close
</button>
</div>
Expand Down
6 changes: 0 additions & 6 deletions src/app/modules/shared/components/details-fields/details-fields.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,9 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {

/* istanbul ignore next */
closeEntryModal() {
this.close();
this.closeModal?.nativeElement?.click();
}

close() {
this.entryForm.reset();
this.cleanForm();
}

onSubmit() {
// start&end date same for now
const entryDate = this.entryForm.value.entry_date;
Expand Down